feat: Prefix and Wildcard in Elastic DSL #6000
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Collaborator
|
Could you please add a test in quickwit/rest-api-tests/scenarii/es_compatibility that you also run against ES? thanks! |
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Darkheir
force-pushed
the
feat/elastic_dsl_prefix_wildcard
branch
from
bf5497e to
4c019ee
Compare
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Darkheir
force-pushed
the
feat/elastic_dsl_prefix_wildcard
branch
from
0da0f62 to
f2681ad
Compare
Contributor
Author
Done :-) |
trinity-1686a
requested changes
Dec 2, 2025
Contributor
trinity-1686a
left a comment
trinity-1686a
left a comment
There was a problem hiding this comment.
lgtm. Can you just change escape sequences to raw strings before we merge?
you don't need to add boost (though you're free to, here or in a follow up, if you want)
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Contributor
Author
|
Thank you for the review :-) I just applied your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
prefixandwildcardquery operators in the elasticsearch DSLHow was this PR tested?
Added unit tests