Improve control plane logging #6003
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload/improve-control-plane-logging-and-metrics
branch
from
15628f2 to
2ada9e0
Compare
guilload
force-pushed
the
guilload/improve-control-plane-logging-and-metrics
branch
from
2ada9e0 to
9e31b68
Compare
|
|
||
| struct SequencePrettyDisplay<I>(I); | ||
|
|
||
| impl<I> fmt::Display for SequencePrettyDisplay<I> |
Contributor
There was a problem hiding this comment.
this code is similar enough to PrettySample that i wonder if SequencePrettyDisplay shouldn't just contain a PrettySample(_, u64::MAX)
Member
Author
There was a problem hiding this comment.
PrettySample relies on Debug whereas for PrettyDisplay I really want to be able to use something other than Debug or Display.
quickwit/quickwit-control-plane/src/ingest/ingest_controller.rs
Outdated
Show resolved
Hide resolved
| return json!({ | ||
| "status": "initializing", | ||
| "shards": [], | ||
| "shards": {}, |
Contributor
There was a problem hiding this comment.
(not for this PR): this kind of change can easily be wrong (as in not all codepath were updated), in the future i think we want a debug_info_internal which returns a struct, and use serde_json::to_value to generate the type-erased value inside debug_info()
guilload
force-pushed
the
guilload/improve-control-plane-logging-and-metrics
branch
from
3fd830c to
3c2d3ca
Compare
trinity-1686a
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding some logging statements and updating the formatting to be less noisy
How was this PR tested?
make test-all