Skip to content

Conversation

@zubairaziz
Copy link
Collaborator

@zubairaziz zubairaziz commented Oct 14, 2025

Bug Fixes

  • Fix WebView reloading by initializing controller only once

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation/refactoring

Testing & Compatibility

  • Tested on iOS and Android
  • Tested OAuth flows (if applicable)
  • Example app verified

Release Checklist

  • Is commit history clean?
    • Do all commit names start with verbs like Add, Fix, Refactor...?
    • Are all commits passing or marked with [WIP]?
  • Are relevant documentation changes queued up?
    • Are the Quiltt API Docs updated?
    • Is the Flutter SDK README updated (if needed)?
    • Are code comments added for complex logic?
  • Version considerations
    • Should this be a patch, minor, or major version bump?
    • Are any breaking changes clearly documented?
    • Add appropriate release label (release:patch, release:minor, release:major) before merging

@zubairaziz zubairaziz requested a review from Copilot October 14, 2025 17:50
@zubairaziz zubairaziz self-assigned this Oct 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a WebView reloading issue by ensuring the WebView controller is initialized only once during the widget lifecycle. The fix prevents redundant controller configuration that was causing unwanted page reloads.

Key changes:

  • Added initialization state tracking to prevent duplicate controller setup
  • Refactored controller setup logic into a dedicated method
  • Enhanced error handling with try-catch blocks around callback invocations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zubairaziz zubairaziz merged commit 248fdad into main Oct 14, 2025
4 checks passed
@zubairaziz zubairaziz deleted the fix-webview-reload branch October 14, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants