Skip to content

Conversation

@claudiavalkenier
Copy link
Contributor

Description

Dataset update of Northern Ireland 2018, in consultation with the Department for the Economy (DfE).
I've added @Charlottevm as content reviewer and @kndehaan as functional reviewer.

Type of change

  • Complete dataset update

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

Copy link
Contributor

@kndehaan kndehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark: in graph_values.yml the full_load_hours of a the following offshore wind technologies is changed to 0:

  • energy_hydrogen_wind_turbine_offshore
  • energy_power_hybrid_wind_turbine_offshore
  • energy_power_wind_turbine_offshore

I would not set full load hours to 0, because if users set capacity for e.g. offshore wind in a scenario, this will lead to 0 production.

If there's no full load hour data for offshore wind, I would either assume the previous value or a similar value as full load hours onshore wind.

energy_power_wind_turbine_offshore:
demand: 0.0
full_load_hours: 2520.0
full_load_hours: 0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be filled in?

Copy link
Contributor

@Charlottevm Charlottevm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to check some numbers a second time before merging, see comments.

demand: 2422.8
energy_power_hybrid_wind_turbine_offshore:
full_load_hours: 2520.0
full_load_hours: 0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be filled in

full_load_hours: 973.0
energy_hydrogen_wind_turbine_offshore:
full_load_hours: 2520.0
full_load_hours: 0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be filled in

demand: 0.0
buildings_final_demand_kerosene:
demand: 476.8347038741
demand: 962.1130721739999
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a big change, good to check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct.

demand: 387.27412582599993
buildings_final_demand_electricity:
demand: 9757.44
demand: 13503.23476
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a big change, good to check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also correct. It includes now 'behind the meter' production, whereas it didn't include that before

:crude_oil: 0.0
buildings_final_demand_diesel:
demand: 191.9376718259
demand: 387.27412582599993
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a big change, good to check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also correct.

demand: 0.0
households_final_demand_coal:
demand: 2731.631419
demand: 5322.734457
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again quite a big change, good to check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's correct!

demand: 0.0
industry_final_demand_coal:
demand: 6221.252398
demand: 3428.696863
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big change, good to check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct

:crude_oil: 1.0
industry_final_demand_diesel:
demand: 5385.701484799999
demand: 1689.6989659409999
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct

demand: 0.0
industry_final_demand_kerosene:
demand: 13379.8089152
demand: 4197.753877059
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem.

Copy link
Contributor Author

@claudiavalkenier claudiavalkenier Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct. Al these changes can be found in the Dataset template UKNI, under 'Energy Balance'.

demand: 0.0
transport_final_demand_kerosene:
demand: 3.381350064
demand: 2632.747251
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very big change, check necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct, it was incorrect in the previous/current dataset (this was assigned to gasoline).

Copy link
Contributor

@kndehaan kndehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants