-
Notifications
You must be signed in to change notification settings - Fork 85
Feature: Session windows #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gwaramadze
wants to merge
19
commits into
main
Choose a base branch
from
feature/session-windows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
782a4c7
Add support for session window
d93de6d
Add fix for serializer
7db4ffe
Fix linters
gwaramadze 587c771
Correct docs
gwaramadze 3d777e7
Rename timeout_ms to inactivity_gap_ms
gwaramadze 3bed367
Remove asserts
gwaramadze bec010b
Tiny refactor
gwaramadze 68687ab
Rename timeout_ms to inactivity_gap_ms in tests
gwaramadze 048020a
Use mock_message_context
gwaramadze e61b999
Remove redundant if
gwaramadze ea35cc0
Move SessionWindow to a dedicated module
gwaramadze 6802727
Introduce FixedTimeWindow intermediary class
gwaramadze 6bee68a
End time equals to last event time
gwaramadze e371715
Lift the equality check from validation to simplify session windows
gwaramadze f2c71fc
Fix end time resolution for out-of-order events
gwaramadze 08dd3d5
Correct docs
gwaramadze 610d38c
Introduce delete_window method to eliminate private member usage
gwaramadze 6c52b8a
Tweak the session windows code
gwaramadze e30c97e
Correct duration validation tests
gwaramadze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.