Skip to content

Enhanced cu function with double precision support #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 7, 2025

Conversation

TendonFFF
Copy link
Contributor

@TendonFFF TendonFFF commented Mar 7, 2025

Checklist

Thank you for contributing to HierarchicalEOM.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to Quantum Toolbox in Julia.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Add optional word_size argument, either Val(64) for double precision (default) or Val(32) for single precision.

@TendonFFF TendonFFF marked this pull request as draft March 7, 2025 08:21
@TendonFFF TendonFFF marked this pull request as ready for review March 7, 2025 08:30
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.82%. Comparing base (623f88f) to head (9ab683c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ext/HierarchicalEOM_CUDAExt.jl 75.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   91.80%   91.82%   +0.02%     
==========================================
  Files          24       24              
  Lines        1513     1517       +4     
==========================================
+ Hits         1389     1393       +4     
  Misses        124      124              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ytdHuang ytdHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ytdHuang ytdHuang merged commit 7f44cc9 into qutip:main Mar 7, 2025
12 of 14 checks passed
@TendonFFF TendonFFF deleted the dev/cu branch March 7, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants