Add feature to adjust fade easing (with Elektra)#2
Open
qwepoizt wants to merge 10 commits intoimprove-config/elektrifyfrom
Open
Add feature to adjust fade easing (with Elektra)#2qwepoizt wants to merge 10 commits intoimprove-config/elektrifyfrom
qwepoizt wants to merge 10 commits intoimprove-config/elektrifyfrom
Conversation
added 7 commits
September 21, 2021 20:06
markus2330
reviewed
Sep 22, 2021
| ElektraEnumFadeEasing easingMode = elektraGetFadeEasing(elektra); | ||
| switch (easingMode) { | ||
| case ELEKTRA_ENUM_FADE_EASING_LINEAR: | ||
| options->easing_mode = EASING_MODE_LINEAR; |
There was a problem hiding this comment.
Why didn't you directly use Elektra's enum?
Owner
Author
There was a problem hiding this comment.
I was probably influenced by my "implementation without Elektra".
Thanks for the hint, I've refactored this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@markus2330: This is patch round 2 of a new configuration value "fade easing" in redshift with Elektra.
Reviewer instructions: I don't have any specific questions for this PR.