-
Notifications
You must be signed in to change notification settings - Fork 12
Add matrix, array and matrix multiplication for integer64 #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hcirellu
wants to merge
14
commits into
r-lib:main
Choose a base branch
from
hcirellu:matrix_array_matmult
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b40f6c1
add matrix, array, %*%.integer64
hcirellu e781e13
fix sys.call level in target_class_for_Ops
hcirellu 400fb45
fix tests to run with ubuntu-latest (3.6) and macos-latest (release)
hcirellu d9e0f7d
fix matrix multiplication for macos
hcirellu 6421d8e
manual debug macos
hcirellu 0777b57
debug macos
hcirellu e48e746
debug macos
hcirellu c6aa44f
debug macos
hcirellu df8a02d
debug macos
hcirellu 58532f2
fix for macos
hcirellu b334ccd
Update R/integer64.R
hcirellu c3245d1
Update R/integer64.R
hcirellu 63a394c
rename `dimO` to `obj_dim`
hcirellu c765dac
`dim` or `dims` is allowed in error message
hcirellu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible for this to be a
chooseOpsMethod()method?https://stat.ethz.ch/R-manual/R-devel/library/base/html/chooseOpsMethod.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my knowledge, we can use
chooseOpsMethod()to achieve thatDate+integer64andinteger64+Dateis handled by+.integer64.Default behaviour: Since both operands have a class attribute, the operation is performed with the warning
Incompatible methods ("+.Date", "+.integer64") for "+"and we get aDateorinteger64, depending on the first argument. In case ofnumeric+integer64this is not necessary, becausenumerichas no class attribute and therefore+.integer64is applied.If we define
chooseOpsMethod.integer64 <- function(x,y,mx,my,cl,rev) TRUE,Date+integer64andinteger64+Dateare handled by+.integer64. This should also apply to all other methods of the Group "Ops", i.e.+,&,==etc, but not%*%orlog.My helper
target_class_for_Opsdoes not address the method selection. It shall determine the desired output class of the result. In the above example it should be thatDate+integer64andinteger64+Dateboth result inDateand notinteger64, if that is added in the function. Right now onlycomplexis assumed to be converted to. In all other cases it is converted tointeger64.