Skip to content

Don't lint expression(paste(., sep = "")) in paste_linter #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't lint expression(paste(., sep = "")) in paste_linter #2955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f87bb69
Don't lint expression(paste(., sep = "")) in paste_linter.
mcol Oct 21, 2025
c592d53
Reworked to fix a false negative.
mcol Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ files in Windows (#2882, @Bisaloo).
* `T_and_F_symbol_linter()` ignores `T` and `F` used as symbols in formulas (`y ~ T + F`), which can represent variables in data not controlled by the author (#2637, @MichaelChirico).
* `T_and_F_symbol_linter()` ignores `T` and `F` if followed by `[` or `[[` (#2944, @mcol).
* `implicit_assignment_linter()` with `allow_scoped=TRUE` doesn't lint for `if (a <- 1) print(a)` (#2913, @MichaelChirico).
* `paste_linter()` doesn't lint `expression(paste(., sep = ""))` (#2945, @mcol).

### Lint accuracy fixes: removing false negatives

Expand Down
8 changes: 7 additions & 1 deletion R/paste_linter.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@
#' )
#'
#' lint(
#' text = 'expression(paste("a", "b", sep = ""))',
#' linters = paste_linter()
#' )
#'
#' lint(
#' text = 'toString(c("a", "b"))',
#' linters = paste_linter()
#' )
Expand Down Expand Up @@ -118,7 +123,8 @@ paste_linter <- function(allow_empty_sep = FALSE,
check_file_paths <- allow_file_path %in% c("double_slash", "never")

paste_sep_xpath <- "
following-sibling::SYMBOL_SUB[text() = 'sep' and following-sibling::expr[1][STR_CONST]]
following-sibling::SYMBOL_SUB[text() = 'sep' and following-sibling::expr[1][STR_CONST]
and not(parent::expr/preceding-sibling::expr/SYMBOL_FUNCTION_CALL[text() = 'expression'])]
/parent::expr
"

Expand Down
5 changes: 5 additions & 0 deletions man/paste_linter.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions tests/testthat/test-paste_linter.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ test_that("paste_linter skips allowed usages for sep=''", {
expect_no_lint("sep <- ''; paste('a', sep)", linter)
expect_no_lint("paste(sep = ',', '', 'a')", linter)
expect_no_lint("paste0('a', 'b', 'c')", linter)
expect_no_lint("expression(paste('a', b, sep = ''))", linter)
})

test_that("paste_linter blocks simple disallowed usages for sep=''", {
Expand All @@ -22,6 +23,18 @@ test_that("paste_linter blocks simple disallowed usages for sep=''", {
rex::rex('paste0(...) is better than paste(..., sep = "").'),
paste_linter()
)

expect_lint(
"paste('a', 'b', expression(2), sep = '')",
rex::rex('paste0(...) is better than paste(..., sep = "").'),
paste_linter()
)

expect_lint(
"c(expression(2), paste('a', 'b', sep = ''))",
rex::rex('paste0(...) is better than paste(..., sep = "").'),
paste_linter()
)
})

test_that("paste_linter skips allowed usages for collapse=', '", {
Expand Down
Loading