Eliminate ATTRIB() use
#87
Merged
+69
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying the pattern from tidyverse/dplyr#7797
hadley
commented
Feb 3, 2026
compile_commands.json
Outdated
| @@ -0,0 +1,22 @@ | |||
| [ | |||
Member
Author
There was a problem hiding this comment.
Am I supposed to gitignore this?
Member
There was a problem hiding this comment.
yep these commands are specific to your setup
hadley
commented
Feb 3, 2026
tests/testthat/_snaps/sxp.md
Outdated
| [1] <INTSXP[10]> (altrep ) | ||
| _class [2] <RAWSXP[144]> () | ||
| _attrib [3] <LISTSXP> () | ||
| _attrib [3] <VECSXP[3]> () |
Member
Author
There was a problem hiding this comment.
Technically a regression, but I'm fine with it.
Member
There was a problem hiding this comment.
hmm it'd be very confusing for such a low level inspection tool to misrepresent data structures involved.
But that was an easy fix (just collect in a pairlist), I just pushed it.
hadley
commented
Feb 4, 2026
| // CHARSXPs have fake attributes | ||
| if (TYPEOF(x) != CHARSXP ) | ||
| size += obj_size_tree(ATTRIB(x), base_env, sizeof_node, sizeof_vector, seen, depth + 1); | ||
| if (TYPEOF(x) != CHARSXP && ANY_ATTRIB(x)) { |
Member
Author
There was a problem hiding this comment.
Now that we have collect_attribs() should we just use it here? Probably a little bit less efficient but that's unlikely to matter?
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the pattern from tidyverse/dplyr#7797