Skip to content

Fix value replacement for sfc_POINT #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix value replacement for sfc_POINT #2345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion R/sfc.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,14 @@ st_sfc = function(..., crs = NA_crs_, precision = 0.0, check_ring_dir = FALSE, d
else
do.call(rbind, value)
attr(x, "points")[i, ] = repl
return(structure(x, n_empty = sum(is.na(attr(x, "points")[,1])))) # RETURNS
return(structure(x,
n_empty = sum(is.na(attr(x, "points")[,1])),
bbox = bbox.pointmatrix(attr(x, "points"))
)) # RETURNS
} else
x = x[] # realize
}
value = value[] # realize in case sfc_POINT while x is not
x = unclass(x) # becomes a list, but keeps attributes
ret = st_sfc(NextMethod(), recompute_bbox = TRUE)
structure(ret, n_empty = sum(sfc_is_empty(ret)))
Expand Down
10 changes: 10 additions & 0 deletions tests/testthat/test_sfc.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,13 @@ test_that("c.sfc n_empty returns sum of st_is_empty(sfg)", {
test_that("st_is_longlat warns on invalid bounding box", {
expect_warning(st_is_longlat(st_sfc(st_point(c(0,-95)), crs = 4326)))
})

test_that("value replacement works for sfc_POINT",{
pts1<-st_geometry(st_as_sf(data.frame(x=1:3,y=1:3), coords = c("x","y")))
pts2<-st_geometry(st_as_sf(data.frame(x=4:5,y=4:5), coords = c("x","y")))
expect_identical(replace(pts1[],2:3,pts2), replace(pts1[],2:3,pts2[]))
expect_identical(replace(pts1,2:3,pts2[])[], replace(pts1[],2:3,pts2[]))
expect_identical(replace(pts1,2:3,pts2)[], replace(pts1[],2:3,pts2[]))
expect_identical(st_bbox(replace(pts1,2:3,pts2)),
st_bbox(replace(pts1[],2:3,pts2[])))# check if bbox is correct without realization
})