Skip to content

mingw-w64-v8: add v8_enable_sandbox=false to build flags #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeroen merged 5 commits into from
Apr 11, 2026
Merged

mingw-w64-v8: add v8_enable_sandbox=false to build flags #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a206903
Try to fix printf linking error
jeroen Apr 11, 2026
21d13b4
Add v8_enable_sandbox=false to build flags
Copilot Apr 11, 2026
ba707f5
Fix linker order issue by wrapping RSP file with --start-group/--end-…
Copilot Apr 11, 2026
f80baf6
Bump build
jeroen Apr 11, 2026
e734ef8
Merge branch 'master' into copilot/add-v8-enable-sandbox-flag
jeroen Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mingw-w64-v8/001-add-mingw-toolchain.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1256,7 +1256,7 @@ diff -ruN --ex build-repo/toolchain/gcc_toolchain.gni build-repo-check/toolchain
# Rust libraries are alpha-sorted instead of by dependencies so they fail
# to link if not properly ordered or grouped.
- link_command = "$ld {{ldflags}}${extra_ldflags} -o \"$unstripped_outfile\" $start_group_flag @\"$rspfile\" $end_group_flag {{solibs}} {{libs}} $start_group_flag {{rlibs}} $end_group_flag"
+ link_command = "$ld {{ldflags}}${extra_ldflags} -o \"$unstripped_outfile\" @\"$rspfile\" $start_group_flag {{solibs}} {{libs}} $end_group_flag {{rlibs}}"
+ link_command = "$ld {{ldflags}}${extra_ldflags} -o \"$unstripped_outfile\" -Wl,--start-group @\"$rspfile\" -Wl,--end-group $start_group_flag {{solibs}} {{libs}} $end_group_flag {{rlibs}}"

# Generate a map file to be used for binary size analysis.
# Map file adds ~10% to the link time on a z620.
Expand Down
5 changes: 3 additions & 2 deletions mingw-w64-v8/PKGBUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ _realname=v8
pkgbase=mingw-w64-${_realname}
pkgname="${MINGW_PACKAGE_PREFIX}-${_realname}"
pkgver=14.6.202.26
pkgrel=1
pkgrel=2
pkgdesc="Fast and modern Javascript engine (mingw-w64)"
arch=('any')
mingw_arch=('mingw64' 'ucrt64' 'clang64' 'clangarm64')
Expand Down Expand Up @@ -70,7 +70,7 @@ sha256sums=('9967736b8381fdf34de72c3f84eebbdb30a867cb94d9a8ff6993504549cc65b5'
'SKIP'
'SKIP'
'SKIP'
'04ccd7b9ff3064bd74d4e521facadf71cdc09c8304fe58cdcf52901a345500da'
'f718e60f47248e7138158b61818631dc1eca582be8122f91e33cf20069e27d1e'
'ebd7b8e2b91e02879cb6c83154cb276be2a820f939b6d166e98b39c175b0eb51'
'274d4cfc5a8a4f99699e67fed36565f315dd3bc0d1335bbf5070ba7052d99541'
'aa7255002773aa3944027e0aab19627eee089c2ec3893713c8c7ff082e214553'
Expand Down Expand Up @@ -224,6 +224,7 @@ build() {
v8_enable_verify_heap=false
v8_symbol_level=${_symbol}
v8_enable_partition_alloc=false
v8_enable_sandbox=false
v8_enable_temporal_support=false
v8_use_external_startup_data=false
chrome_pgo_phase=0
Expand Down
Loading