fix: update cargo-deny config for new advisories and licenses#1006
Merged
AlexD10S merged 1 commit intor0gue-io:mainfrom Feb 24, 2026
Merged
fix: update cargo-deny config for new advisories and licenses#1006AlexD10S merged 1 commit intor0gue-io:mainfrom
AlexD10S merged 1 commit intor0gue-io:mainfrom
Conversation
- Clean up advisory ignore list, remove resolved entries and add new ones - Add CDLA-Permissive-2.0 to allowed licenses - Add OpenSSL exception for aws-lc-sys - Bump git2 to 0.20.4 and git2_credentials to 0.15.0
Member
Author
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1006 +/- ##
==========================================
- Coverage 57.71% 56.69% -1.03%
==========================================
Files 176 176
Lines 42783 42783
Branches 42783 42783
==========================================
- Hits 24692 24255 -437
- Misses 15778 16216 +438
+ Partials 2313 2312 -1 see 51 files with indirect coverage changes 🚀 New features to boost your workflow:
|
moliholy
approved these changes
Feb 24, 2026
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo deny check advisoriesandcargo deny check licensesthat were currently failinggit2andgit2_credentialsto resolve theRUSTSEC-2024-0344advisory.Discussion
In the ignored vulnerabilities section, replace references to individual GitHub issues with a generic explanatory message. This will allow us to close the remaining open vulnerability tracking issues: https://github.com/r0gue-io/pop-cli/issues?q=is%3Aissue%20state%3Aopen%20Vulnerability%20dependency
Closes #458 #451 #450 #438 #437 #436 #214