fix: Allow pop build spec to specify the runtime path as argument#687
Merged
tsenovilla merged 15 commits intomainfrom Oct 22, 2025
Merged
Conversation
Collaborator
Author
|
Tried functionality on Paseo with: and compared the generated raw file with the old one. It looks super good, just one thing caught my attention:
We should be able to include this on Paseo workflows soon ;) |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 76.95% 76.84% -0.11%
==========================================
Files 109 109
Lines 24609 24549 -60
Branches 24609 24549 -60
==========================================
- Hits 18937 18865 -72
- Misses 3690 3695 +5
- Partials 1982 1989 +7
🚀 New features to boost your workflow:
|
moliholy
reviewed
Oct 22, 2025
moliholy
reviewed
Oct 22, 2025
moliholy
reviewed
Oct 22, 2025
moliholy
reviewed
Oct 22, 2025
Collaborator
|
Works like a charm! Many thanks for making this command shine ✨ |
moliholy
approved these changes
Oct 22, 2025
moliholy
approved these changes
Oct 22, 2025
moliholy
approved these changes
Oct 22, 2025
AlexD10S
reviewed
Oct 22, 2025
AlexD10S
approved these changes
Oct 22, 2025
Member
AlexD10S
left a comment
There was a problem hiding this comment.
LGTM! Excited to see this in the Paseo CI.
Thanks for the last fixes and nitpicks
AlexD10S
approved these changes
Oct 22, 2025
…ime-dir-as-command
moliholy
pushed a commit
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
pop build spec#685This PR will:
pop build specon CIs (eg, Paseo) by letting the user pass the runtime dir path as argument. This wasn't possible before asfind_runtime_dirautomatically prompts the user if there's not a "runtime" folder on the call path (which is the case for Paseo) <- This isn't nice for CIs.find_workspace_tomlfunction as it's not correctly supporting not prefixed inputs like "system-chains/bridge-hub-paseo". I detected this a while ago when I was working on feat: new commandpop add pallet#524 and added a fixed version to this crate, which was gonna be added to Pop-CLI on that PR. Let's add it now and also leverage we have it to get rid ofadd_crate_to_workspace, reducing pop codebase's size.