Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #394 +/- ##
===========================================
+ Coverage 54.34% 68.41% +14.06%
===========================================
Files 49 70 +21
Lines 5025 11838 +6813
Branches 5025 11838 +6813
===========================================
+ Hits 2731 8099 +5368
- Misses 2245 3482 +1237
- Partials 49 257 +208 |
chungquantin
approved these changes
Nov 27, 2024
Contributor
chungquantin
left a comment
There was a problem hiding this comment.
Nice to have basic examples (similar to the one in mock test). In overall, I'm happy with the doc, very well-written!
Collaborator
Author
|
You mean adding examples to the readme? |
Contributor
Looking at the existing code in the testnet runtime, there are a lot of noises aside from the direct configuration of the module. Something like the code snippet below could be useful for someone that interested to use this in their code. struct ExampleFunction;
...
pub(crate) type Functions = (
ExampleFunction<WithFuncId<ExampleFuncId>, Runtime>,
);
#[derive(Default)]
pub struct Config;
impl super::Config for Config {
type Functions = Functions;
const LOG_TARGET: &'static str = "pop-chain-extension";
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.