feat(spike): cross-chain nonfungible implementation#400
Open
chungquantin wants to merge 102 commits intomainfrom
Open
feat(spike): cross-chain nonfungible implementation#400chungquantin wants to merge 102 commits intomainfrom
chungquantin wants to merge 102 commits intomainfrom
Conversation
…fts' into chungquantin/feat-nfts
This reverts commit 672ceae.
eba2458 to
7332079
Compare
76a0d8e to
e0d13f2
Compare
Contributor
Author
You can view the changes if we remove the incrementable trait here #406. Imo, the current approach in this PR is cleaner as it does not remove any thing related to functionality in the pallet-nfts, mainly changes in the CollectionId trait and data ownership. |
dc2c68f to
4b4cd22
Compare
6ab88c1 to
f83bdc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Blocked by: #387
The pull request implements the
NonFungiblesTransactorusing theForeignNftspallet nfts instance. This makes changes to the pallet-nftsCollectionIdtype to remove theCopyrequired parameter trait asxcm::latest::Locationis not implemented withCopy. Replace all the copies ofCollectionIdin the pallet-nfts code to useClone. Performance benchmarking should be considered to see if there is a huge change in the memory efficiency.MultiLocationCollectionIdimplemented withxcm::latest::LocationNonFungiblesTransactorForeignNftsinstance and runtime configurationOutcome