fix(proxy): NonTrasnfer Proxy rejects contracts related calls#579
Open
fix(proxy): NonTrasnfer Proxy rejects contracts related calls#579
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #579 +/- ##
=======================================
Coverage 63.47% 63.47%
=======================================
Files 121 121
Lines 23838 23838
Branches 23838 23838
=======================================
Hits 15130 15130
Misses 7664 7664
Partials 1044 1044
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved #574 by filtering our contract related calls for
NonTransferproxy type.As contracts are able to transfer funds a call, users of
NonTrasnferproxy could have bypassed the purpose of said account prior to this change.