Added .setResponseType handling#24
Open
juskrey wants to merge 3 commits intor0man:masterfrom
juskrey:master
Open
Added .setResponseType handling#24juskrey wants to merge 3 commits intor0man:masterfrom juskrey:master
juskrey wants to merge 3 commits intor0man:masterfrom
juskrey:master
Conversation
|
+1 |
|
Any chance this pull request gets merged? Thank you. |
Owner
|
@danskarda I agree that we should return the response under the :body key in this case as well. Updated patch with tests welcome! Also, is this only working in Webkit? http://closure-library.googlecode.com/git-history/docs/class_goog_net_XhrIo.html |
Author
|
I'll look into it, considering the new updates (plus the comment about optional :body). |
|
Definitely should be added, I'm downloading torrent files and need a binary option. Have to switch to cljs-ajax for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suitable for e.g. arraybuffers requests. Takes standard values, as in goog.net.XhrIo.ResponseType
Example:
Defaults to ""
In the returned map, adds :response-type key, which returns (.getResponseType target) for response consistency checking and
:response, which returns (.getResponse target), the proper way of handling non-default request types.