client: pass the provided ctx to backoff.RetryNotify#146
Open
wwade wants to merge 1 commit intor3labs:masterfrom
Open
client: pass the provided ctx to backoff.RetryNotify#146wwade wants to merge 1 commit intor3labs:masterfrom
wwade wants to merge 1 commit intor3labs:masterfrom
Conversation
If we hit a connection error in any of the ..WithContext functions, we end up blocked in the backoff.RetryNotify loop. This loop can use a context, but it needs to be bound to the BackOff provided when RetryNotify is called. Added a test case `TestSubscribeWithContextAbortRetrier` to demonstrate the problem and verify the fix. Fixes r3labs#131.
Author
|
@purehyperbole mind having a look at this one? |
Author
|
@merlinran mind having a look? |
merlinran
approved these changes
Feb 27, 2023
Contributor
merlinran
left a comment
merlinran
left a comment
There was a problem hiding this comment.
This looks like a neat solution which solves the problem it intended to solve. I'm not part of the org so still need the members to decide if merge or not.
Author
Ah, gotcha, well, thanks for the review just the same! |
Author
|
bump @purehyperbole 😄 |
Author
|
@purehyperbole would appreciate your review to get this one merged if it looks ok. |
Author
|
@purehyperbole could you please have a look at merging this? |
|
@purehyperbole Is this package still maintained? @reidjc As the only other publicly visible member of the r3labs organization, can you comment on the status of this repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we hit a connection error in any of the ..WithContext functions, we end up blocked in the backoff.RetryNotify loop. This loop can use a context, but it needs to be bound to the BackOff provided when RetryNotify is called.
Added a test case
TestSubscribeWithContextAbortRetrierto demonstrate the problem and verify the fix.Fixes #131.