add NewClientFromReq method to allow streaming any kind of requests#164
Open
radiantspace wants to merge 1 commit intor3labs:masterfrom
Open
add NewClientFromReq method to allow streaming any kind of requests#164radiantspace wants to merge 1 commit intor3labs:masterfrom
radiantspace wants to merge 1 commit intor3labs:masterfrom
Conversation
Allows making sse clients from any kind of requests, not just GET
wuhan005
suggested changes
Aug 28, 2024
Comment on lines
+309
to
+310
| if c.Request != nil { | ||
| } else { |
There was a problem hiding this comment.
Suggested change
| if c.Request != nil { | |
| } else { | |
| if c.Request == nil { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows making sse clients from any kind of requests, not just GET.
I needed that for streaming responses from OpenAI like this:
Closes #153