Skip to content

Conversation

@lukebakken
Copy link
Collaborator

This reduces the number of extraneous auth queries to vhosts that aren't relevant.

Fixes #14923

@lukebakken lukebakken self-assigned this Nov 11, 2025
@lukebakken lukebakken force-pushed the lukebakken/rabbitmq-server-14923 branch 4 times, most recently from 2979489 to c12f65e Compare November 11, 2025 16:17
@lukebakken lukebakken marked this pull request as ready for review November 11, 2025 16:23
@lukebakken lukebakken marked this pull request as draft November 11, 2025 16:23
@lukebakken lukebakken marked this pull request as ready for review November 11, 2025 16:24
@lukebakken lukebakken force-pushed the lukebakken/rabbitmq-server-14923 branch from 67ac21b to 3ca3390 Compare November 11, 2025 19:49
@michaelklishin michaelklishin changed the title When vhost is known, limit auth to that vhost HTTP API: when virtual host is known, limit permission filtering to just that specific virtual host Nov 12, 2025
This reduces the number of extraneous auth queries to vhosts that aren't
relevant.

These changes also provide friendlier formatting in
`log_access_control_result`

Fixes rabbitmq#14923
@lukebakken lukebakken force-pushed the lukebakken/rabbitmq-server-14923 branch from 3ca3390 to e8d9218 Compare November 12, 2025 18:56
@lukebakken
Copy link
Collaborator Author

I'm pretty sure my changes in deps/rabbitmq_web_dispatch/src/rabbit_web_dispatch_access_control.erl are logically equivalent but second and third sets of 👀 are appreciated of course 😸

@michaelklishin michaelklishin added this to the 4.3.0 milestone Nov 12, 2025
@michaelklishin michaelklishin merged commit b7d6bf9 into rabbitmq:main Nov 12, 2025
289 of 290 checks passed
michaelklishin added a commit that referenced this pull request Nov 13, 2025
HTTP API: when virtual host is known, limit permission filtering to just that specific virtual host (backport #14931)
@lukebakken lukebakken deleted the lukebakken/rabbitmq-server-14923 branch November 13, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants