-
Notifications
You must be signed in to change notification settings - Fork 4k
Merge stream.read_ahead and stream.read_ahead_limit options (backport #14894)
#14948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
01979d8 to
bfe6054
Compare
|
Oh, I guess my last backport I messed up the conflicts and introduced a duplicate definition rabbitmq-server/deps/rabbit/priv/schema/rabbit.schema Lines 2779 to 2795 in 7e43377
Working on the fix... |
Read-ahead can be controlled by a single option, with zero acting the same as `false`. (cherry picked from commit 76ce4ee) # Conflicts: # deps/rabbit/src/rabbit_stream_queue.erl
bfe6054 to
7b93c92
Compare
|
|
||
| %% See github.com/rabbitmq/osiris#192 and https://github.com/rabbitmq/rabbitmq-server/commit/9f162dfd01c1516d168e7d1fad39d33a929756e5 | ||
| %% Enables read-head | ||
| {mapping, "stream.read_ahead", "rabbit.stream_read_ahead", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally moved or duplicated this last time
| []}, | ||
|
|
||
| %% | ||
| %% Stream read ahead on/off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, this was duplicated, probably because of conflicts
Read-ahead can be controlled by a single option, with zero acting the same as
false.This is the companion change for rabbitmq/osiris#199 - see extra context there. This replaces the config option in #14888.
This is an automatic backport of pull request #14894 done by [Mergify](https://mergify.com).