Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 12, 2025

Read-ahead can be controlled by a single option, with zero acting the same as false.

This is the companion change for rabbitmq/osiris#199 - see extra context there. This replaces the config option in #14888.

# prevent any read-ahead
stream.read_ahead = false
# tune read-ahead limit
stream.read_ahead = 8kiB

This is an automatic backport of pull request #14894 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Nov 12, 2025
@mergify

This comment was marked as resolved.

@mergify mergify bot added the make label Nov 12, 2025
@the-mikedavis the-mikedavis force-pushed the mergify/bp/v4.2.x/pr-14894 branch from 01979d8 to bfe6054 Compare November 12, 2025 21:33
@michaelklishin michaelklishin added this to the 4.2.1 milestone Nov 12, 2025
@the-mikedavis
Copy link
Collaborator

Oh, I guess my last backport I messed up the conflicts and introduced a duplicate definition

{mapping, "stream.read_ahead", "rabbit.stream_read_ahead",
[{datatype, {enum, [true, false]}}]}.
{mapping, "stream.read_ahead_limit", "rabbit.stream_read_ahead_limit", [
{datatype, [integer, string]},
{validators, ["is_supported_information_unit"]}
]}.
{mapping, "cluster_tags.$tag", "rabbit.cluster_tags", [
{datatype, [binary]}
]}.
%% See github.com/rabbitmq/osiris#192 and https://github.com/rabbitmq/rabbitmq-server/commit/9f162dfd01c1516d168e7d1fad39d33a929756e5
%% Enables read-head
{mapping, "stream.read_ahead", "rabbit.stream_read_ahead",
[{datatype, {enum, [true, false]}}]}.

Working on the fix...

Read-ahead can be controlled by a single option, with zero acting the
same as `false`.

(cherry picked from commit 76ce4ee)

# Conflicts:
#	deps/rabbit/src/rabbit_stream_queue.erl
@the-mikedavis the-mikedavis force-pushed the mergify/bp/v4.2.x/pr-14894 branch from bfe6054 to 7b93c92 Compare November 12, 2025 23:55

%% See github.com/rabbitmq/osiris#192 and https://github.com/rabbitmq/rabbitmq-server/commit/9f162dfd01c1516d168e7d1fad39d33a929756e5
%% Enables read-head
{mapping, "stream.read_ahead", "rabbit.stream_read_ahead",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally moved or duplicated this last time

[]},

%%
%% Stream read ahead on/off
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, this was duplicated, probably because of conflicts

@the-mikedavis the-mikedavis merged commit dec4e24 into v4.2.x Nov 13, 2025
575 of 577 checks passed
@the-mikedavis the-mikedavis deleted the mergify/bp/v4.2.x/pr-14894 branch November 13, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants