Implement heartbeat #141
Closed
Implement heartbeat #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akloboucnik
force-pushed
the
handle-heartbeat
branch
from
1e6f556 to
0f74751
Compare
akloboucnik
force-pushed
the
handle-heartbeat
branch
from
0f74751 to
fb44ccc
Compare
Merged
Contributor
|
@akloboucnik from our experience with heartbeat implementations in other clients (not just RabbitMQ Stream Protocol ones), it is notoriously difficult to integration test. I'd be happy to test this PR, perhaps do a bit of renaming and try to get it over the line. Would that be OK with you? |
Collaborator
|
this was stalled and basically the worked has been finished here Let in case let me know if you have time to test it :) |
Contributor
|
@wolf4ood ah, I see. So this should be closed then. |
Member
|
@wolf4ood we can close this, right? |
Contributor
Author
|
@michaelklishin Sorry, I had to move on working on more pressing things at work and never got back to this :-( @wolf4ood Thank you for implementing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My take on #95.
I based the impementation on https://docs.google.com/presentation/d/1Hlv4qaWm2PRU04dVPmShP9wU7TEQEttXdsbV8P54Uvw/edit#slide=id.ge4c0ef0fc0_0_2 and https://www.rabbitmq.com/heartbeats.html#heartbeats-interval
TODO