Open
Conversation
Owner
|
Actually I don't want to add dependencies for the filters added to Template::Flute. The prerequisites for the filters are in the documentation. |
Contributor
Author
|
So, should I simply remove those dependencies, update the branch, and |
Owner
|
Yes, please. |
Even though the distribution installs and builds correctly, mentioning all required modules helps things like metacpan find and display the correct dependencies. This helps the dist's kwalitee and aids in determining the "river of CPAN" (see http://neilb.org/2015/04/20/river-of-cpan.html), which is good for the entire Perl module ecosystem.
The list of modules used to test `Template::Flute` is now complete. This helps improve distribution kwalitee and helps out services such as metacpan get the dependency list correct.
I know we already discussed this on IRC, but I happened to find that the minimum version was actually higher than 5.6. It turns out that certain minimum syntax features used in Template::Flute require at least 5.8, thus it would help anyone installing the module on an old system (and anyone testing on old systems) if they knew early on that the module won't work without at least this minimum version. Hence, I've added this commit here. It's also not a large change, so I hope you can accept it.
paultcochrane
force-pushed
the
pr/improve-kwalitee
branch
from
e14730a to
ed4c72d
Compare
Contributor
Author
|
Have updated the commits and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A set of changes to improve the distribution's kwalitee (http://cpants.cpanauthors.org/dist/Template-Flute).