You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the rating service for Chargeback, recently added to openstack-helm. tested the deployment and api calls work. At this time there is no Skyline module for cloudkitty but there is a horizon dashboard module that should work.
The reason will be displayed to describe this comment to others. Learn more.
functionally, this looks fine, however we need the boilerplate github actions added to validate the helm, kustomize, and potentially add it to the smoke tests
The reason will be displayed to describe this comment to others. Learn more.
We are missing the managed by helm-label here. similiar to this:
labels:
app.kubernetes.io/managed-by: "Helm"
annotations:
helm.sh/resource-policy: keep
meta.helm.sh/release-name: "cloudkitty"
meta.helm.sh/release-namespace: "openstack"
One more change, please take a look at an install script from another service to see the format and make sure to add the helm version of your servce in the helm-chart-versions.yaml.
The reason will be displayed to describe this comment to others. Learn more.
The helm version has been moved to genestack/helm-chart-versions.yaml. Please update this install script to conform with the standard (the other services).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the rating service for Chargeback, recently added to openstack-helm. tested the deployment and api calls work. At this time there is no Skyline module for cloudkitty but there is a horizon dashboard module that should work.