Refactor search placeholder #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML supports the placeholder attribute, so we should use it instead of implementing it ourselves. The placeholder attribute is not available prior IE10 (not including IE10). However: 1. In non-supporting browsers (e.g., IE9), the search functionality should still work correctly. 2. Non-supporting browsers don't qualify for the "full support" level detailed in racket#240 IE9 for instance is released in 2011, and Microsoft announced its end of support in 2016.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML supports the placeholder attribute, so we should use it
instead of implementing it ourselves.
The placeholder attribute is not available prior IE10 (not including
IE10). However:
should still work correctly.
detailed in Add browser support policy for Scribble-generated documentation. #240
IE9 for instance is released in 2011, and Microsoft announced its end of
support in 2016.
Also, technically this is a bug fix. Currently, if users type
...search manuals...as a search query, focus somewhere else, and then focus the search box again, the text will disappear.