refactor: modernize JS in scribble-common.js #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 0 files in this pull request and found no issues.
|
As a side effect, this handles query string much better than what it currently does. For example, the malformed query string in #329 / greghendershott/racket-mode#623 can now be decoded with no issue. |
sorawee
force-pushed
the
refactor-scribble-common
branch
from
b213e23 to
96fe38e
Compare
There was a problem hiding this comment.
Resyntax analyzed 0 files in this pull request and found no issues.
yfzhe
reviewed
Oct 16, 2023
yfzhe
reviewed
Oct 16, 2023
Browsers released within the last 5 years (the partial support tier according to #240) support URLSearchParams, so we should use it.
sorawee
force-pushed
the
refactor-scribble-common
branch
from
96fe38e to
85bc528
Compare
|
Thank you for the feedback, @yfzhe! |
There was a problem hiding this comment.
Resyntax analyzed 0 files in this pull request and found no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers released within the last 5 years (the partial support tier according to #240) support URLSearchParams, so we should use it.