Skip to content

Conversation

@asiloh
Copy link

@asiloh asiloh commented Nov 5, 2025

This PR contains a wide-ranging rewrite of the Traditional Chinese translation. The old one was from four years ago, and Chongkai Zhu’s version uses terminology of Mainland China. Since most Traditional Chinese native consumer are in Taiwan, I switched to Taiwan-standard terminology, especially for science/engineering where the differences are big and mixing them gets confusing.

An all-new Traditional Chinese translation based on the latest English original.
@asiloh asiloh marked this pull request as draft November 5, 2025 02:38
@asiloh asiloh marked this pull request as ready for review November 5, 2025 02:46
@asiloh asiloh marked this pull request as draft November 5, 2025 09:02
Some translated sentences have been modified.
@asiloh asiloh marked this pull request as ready for review November 5, 2025 09:30
@rfindler
Copy link
Member

rfindler commented Nov 5, 2025

Thank you for putting in the time to work on this! I am not qualified to comment on the specifics of the translation (although if no Taiwanese rings in, I'll try to do my best), but I do see that there are compile time errors in the current version of this file. This is the first one that's reported:

string-constants-lib/string-constants/private/traditional-chinese-string-constants.rkt:148:3: string-constant-lang: expected a string that begins with a space

The issue here is that there is a rule that anytime there are multiple strings, they will be combined together and there must be a space at the start of each new constant. This intent of this rule is to make it easier to avoid double spaces or missing spaces when breaking lines, as the strings are just blindly concatenated.

It does seem like the rule could be loosened a little bit so that, when the previous string ends with a newline, then it is okay to not start with a space, however.

@asiloh
Copy link
Author

asiloh commented Nov 6, 2025

Thanks for the explanation! I've and added the missing spaces. Hopefully the new commit didn't miss anything!

@rfindler
Copy link
Member

rfindler commented Nov 8, 2025

When you start DrRacket with the translation, the menus are in the wrong order. That's because this portion of the file starting at line 823 needs to look like this, without the menu shortcuts:

  ;;; raw menu names -- these must match the
  ;;; versions below, once the &s have been stripped.
  ;;; if they don't, DrRacket's menus will appear
  ;;; in the wrong order.
  (file-menu "檔案")
  (edit-menu "編輯")
  (help-menu "說明")
  (windows-menu "視窗")
  (tabs-menu "分頁") ;; this is the name of the "Windows" menu under linux & windows

@asiloh
Copy link
Author

asiloh commented Nov 8, 2025

Thanks! I’ve cleared those shortcuts, and it now seems to work in my DrRacket.
(PS: The pop-up context menu still has a few items that aren’t translated. It looks like english-string-constants.rkt is missing some string-constants, or some GUI text isn’t using string-constants. I’ve seen the same in other localizations. I’ll see if I can patch this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants