Propagate a trivial expected type for recursive lambda if neccessary #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 7 files in this pull request and found no issues.
samth
force-pushed
the
fix/kw-expected-types
branch
from
972e88f to
6d238b0
Compare
There was a problem hiding this comment.
Resyntax analyzed 7 files in this pull request and found no issues.
samth
force-pushed
the
fix/kw-expected-types
branch
from
6d238b0 to
e1ba235
Compare
This does not apply an expected type to the actual function body, it just gives a type to the function when referred to recursively. This addresses a problem with inference for let loop in lambda as the argument to `thread` now that `thread` is a keyword function and therefore lifts its arguments to a `let` ahead of the function. Fixing the relevant problem also requires improving the type of `thread`.
samth
force-pushed
the
fix/kw-expected-types
branch
from
e1ba235 to
8822efa
Compare
There was a problem hiding this comment.
Resyntax analyzed 7 files in this pull request and found no issues.
There was a problem hiding this comment.
Resyntax analyzed 8 files in this pull request and found no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not apply an expected type to the actual function body,
it just gives a type to the function when referred to recursively.
This addresses a problem with inference for let loop in lambda as
the argument to
threadnow thatthreadis a keyword function andtherefore lifts its arguments to a
letahead of the function.Fixing the relevant problem also requires improving the type of
thread.