Fix for issue #37#41
Open
javatenor wants to merge 2 commits intoracodond:masterfrom
Open
Conversation
added 2 commits
December 18, 2019 08:46
…hSide annotation to ScannerSide
Owner
|
Hi @javatenor, Thanks for the PR. Thank you David |
Author
|
Hi,
Yes, I noticed your comment in readme.
I think I don’t have time to maintain it, can hardly maintain my self :)
Just made a quick fix for our company needs and thought that PR might help someone else if no one maintains this plugin anymore.
…-Erkki
David RACODON ***@***.***> kirjoitti 18.12.2019 kello 22.31:
Hi @javatenor,
Thanks for the PR.
I don't want to keep maintaining this plugin: https://github.com/racodond/sonar-json-plugin#disclaimer
So, feel free to fork and take over.
Thank you
David
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minimum changes to fix issue #37: