Added ability to specify a default url in the config. #29
Added ability to specify a default url in the config. #29bobjohnbob wants to merge 1 commit intoradiosilence:masterfrom
Conversation
…d are instead subpaths unless they start with protocol://
|
This is my first pull request. Constructive criticism encouraged, but please be gentle ;) |
| function getURI(opts) { | ||
| let uri = opts.url; | ||
| let subPath = opts.subPath | ||
| if(!uri|| subPath.indexOf("://") !== -1) { |
There was a problem hiding this comment.
A substantial number of users are likely to use 'protocol relative' urls - which will not contain ://
This probably won't break existing implementations (since folks are unlikely to have specified a default url as the base url) - however it will prevent the usage of the override should a base url be specified during initialization.
|
Thanks for taking the time to review my changes and provide valuable input, @masterful. If @radiosilence decides this is a feature he would like to merge in, I am willing to put in the work to fix the code to address these comments. I will probably do it anyways in my own fork, when I have time :) |
2 participants
This pull request allows users to set the url with the config. To accommodate this, the first parameter to a GET/POST/etc request is now instead considered a subPath to that url.
If no url is configured, the subPath is treated as a url.
Also, if the subPath begins with
{protocol}://the configured url is ignored.This should prevent breaking the old API and allow the developer to specify a default
protocol://domain:port/basePathto use on all requests. This is particularly useful if you're making a bunch of calls to an api across domains.