Skip to content

Conversation

@brooke-hamilton
Copy link
Member

@brooke-hamilton brooke-hamilton commented Jan 23, 2026

Summary

This PR improves the pyspelling configuration to reduce false positives during spell checking by excluding URLs and markdown image links.

Changes

Modified file: .github/config/.pyspelling.yml

  • Added pyspelling.filters.url filter to exclude URLs from spell checking

These filters prevent the spell checker from flagging file paths in image links and URLs as misspelled words.

Testing

On the main branch of this repo, follow the README.md instructions to run pyspelling on your machine, like this:

pyspelling --verbose --config ./.github/config/.pyspelling.yml`

Observer several spelling errors.

Change to the branch for this PR, and test again. You should see the errors do not exist.

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
@brooke-hamilton brooke-hamilton requested review from a team as code owners January 23, 2026 16:39
Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brooke-hamilton this makes sense to me, but I was wondering if this will cause us to skip misspelled image file names?

@brooke-hamilton brooke-hamilton merged commit e762a4c into radius-project:main Jan 23, 2026
2 checks passed
@brooke-hamilton
Copy link
Member Author

@brooke-hamilton this makes sense to me, but I was wondering if this will cause us to skip misspelled image file names?

Yes, it's a tradeoff in terms of having to either allow misspelled words in image names vs having to add things like "kHTPUX" to the dictionary. I'm open to further refinement of this for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants