Usability: rad recipe show does not show parameter values #11005

Alec13355 · 2026-01-06T15:05:08Z

Fixes issue where 'rad recipe show' displayed 'null' instead of actual configured parameter values like 'eastus' and 'my-rg'.

Description

Please explain the changes you've made.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
Usability: rad recipe show does not show parameter values #9454

Fixes: #9454

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

actual configured parameter values like 'eastus' and 'my-rg'. Signed-off-by: Alec13355 <aah1@mac.com>

…cccb1a2b8 to 082deb6cee063d5b8ce740fbee614460d2c2211b in the github-actions group (radius-project#11001) Bumps the github-actions group with 1 update: [securego/gosec](https://github.com/securego/gosec). Updates `securego/gosec` from 538a05cc5d6eb7bb41624e48f6e5019cccb1a2b8 to 082deb6cee063d5b8ce740fbee614460d2c2211b <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/securego/gosec/commit/082deb6cee063d5b8ce740fbee614460d2c2211b"><code>082deb6</code></a> whitelist crypto/rand Read from error checks (<a href="https://redirect.github.com/securego/gosec/issues/1446">#1446</a>)</li> <li><a href="https://github.com/securego/gosec/commit/095d529a906cabaf1adbea5e85fc13acce092a53"><code>095d529</code></a> chore(deps): update all dependencies (<a href="https://redirect.github.com/securego/gosec/issues/1443">#1443</a>)</li> <li><a href="https://github.com/securego/gosec/commit/c073629009897d89e03229bc81232c7375892086"><code>c073629</code></a> Improve slice bound check (<a href="https://redirect.github.com/securego/gosec/issues/1442">#1442</a>)</li> <li>See full diff in <a href="https://github.com/securego/gosec/compare/538a05cc5d6eb7bb41624e48f6e5019cccb1a2b8...082deb6cee063d5b8ce740fbee614460d2c2211b">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Alec13355 <aah1@mac.com>

…0999) # Description This pull request adds support for a new `x-radius-sensitive` annotation in schema definitions, allowing string and object types to be marked as sensitive for downstream processing. Updates for manifest schema validation to follow in separate PR. ref: Design Doc: [2025-11-11-secrets-redactdata](https://github.com/radius-project/design-notes/blob/main/resources/2025-11-11-secrets-redactdata.md) - This pull request adds or changes features of Radius and has an approved issue (issue link radius-project#10421). Fixes: radius-project#10421 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - An overview of proposed schema changes is included in a linked GitHub issue. - [] Yes  - [x] Not applicable  - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [x] Yes  - [] Not applicable  - The design document has been reviewed and approved by Radius maintainers/approvers. - [x] Yes  - [] Not applicable  - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [] Yes  - [x] Not applicable  - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [] Yes  - [x] Not applicable  - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [] Yes  - [x] Not applicable  Signed-off-by: lakshmimsft <ljavadekar@microsoft.com> Signed-off-by: Alec13355 <aah1@mac.com>

Signed-off-by: Alec13355 <aah1@mac.com>

radius-project#10963) # Description * Update Radius DE sync: radius side (https://github.com/azure-octo/deployment-engine/pull/514) ## Type of change  - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). ## Contributor checklist Please verify that the PR meets the following requirements, where applicable:  - An overview of proposed schema changes is included in a linked GitHub issue. - [ ] Yes  - [x] Not applicable  - A design document PR is created in the [design-notes repository](https://github.com/radius-project/design-notes/), if new APIs are being introduced. - [ ] Yes  - [x] Not applicable  - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes  - [x] Not applicable  - A PR for the [samples repository](https://github.com/radius-project/samples) is created, if existing samples are affected by the changes in this PR. - [ ] Yes  - [x] Not applicable  - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes  - [x] Not applicable  - A PR for the [recipes repository](https://github.com/radius-project/recipes) is created, if existing recipes are affected by the changes in this PR. - [ ] Yes  - [x] Not applicable  --------- Signed-off-by: willdavsmith <willdavsmith@gmail.com> Signed-off-by: Alec13355 <aah1@mac.com>

ytimocin

Would you like to try to add a functional test for this addition?

Copilot

Pull request overview

This PR fixes a bug where rad recipe show displayed 'null' instead of actual configured parameter values (like 'eastus' and 'my-rg') when parameters were set in the environment configuration.

Key Changes:

Added environment resource retrieval to fetch configured parameter values
Modified parameter display logic to prefer environment values over template defaults
Added comprehensive test coverage for the new functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
pkg/cli/cmd/recipe/show/show.go	Added logic to fetch environment resource and override template parameter defaults with environment-specific values
pkg/cli/cmd/recipe/show/show_test.go	Added helper function `setupTestClient`, two new test cases for environment parameter scenarios, and fixed typo in existing test name

Copilot · 2026-01-07T07:21:20Z

pkg/cli/cmd/recipe/show/show.go


+	// Get environment-specific parameter values for this recipe (if environment is available)
+	var environmentParameters map[string]any
+	if environment != nil && environment.Properties.Recipes != nil {


Missing nil check for environment.Properties before accessing environment.Properties.Recipes. According to the EnvironmentResource struct definition, Properties is a pointer field that could be nil, which would cause a panic. Add a nil check for Properties before checking Recipes.

Suggested change

if environment != nil && environment.Properties.Recipes != nil {

if environment != nil && environment.Properties != nil && environment.Properties.Recipes != nil {

pkg/cli/cmd/recipe/show/show_test.go

Copilot · 2026-01-07T07:21:21Z

pkg/cli/cmd/recipe/show/show_test.go

+	t.Run("Show recipe details when GetEnvironment fails - Success", func(t *testing.T) {
+		ctrl := gomock.NewController(t)
+		envRecipe := v20231001preview.RecipeGetMetadataResponse{
+			TemplateKind: to.Ptr(recipes.TemplateKindBicep),
+			TemplatePath: to.Ptr("ghcr.io/testpublicrecipe/bicep/modules/openai:v1"),
+			Parameters: map[string]any{
+				"location": map[string]any{
+					"type":         "string",
+					"defaultValue": "westus",
+				},
+				"resource_group_name": map[string]any{
+					"type":         "string", 
+					"defaultValue": "null",
+				},
+			},
+		}
+		recipe := types.EnvironmentRecipe{
+			Name:         "default",
+			ResourceType: "Radius.Resources/openAI",
+			TemplateKind: recipes.TemplateKindBicep,
+			TemplatePath: "ghcr.io/testpublicrecipe/bicep/modules/openai:v1",
+		}
+
+		// Expected parameters should show template defaults since environment call fails
+		recipeParams := []types.RecipeParameter{
+			{
+				Name:         "resource_group_name",
+				Type:         "string",
+				MaxValue:     "-",
+				MinValue:     "-",
+				DefaultValue: "null", // Template default since environment fails
+			},
+			{
+				Name:         "location",
+				Type:         "string",
+				MaxValue:     "-",
+				MinValue:     "-",
+				DefaultValue: "westus", // Template default since environment fails
+			},
+		}
+
+		appManagementClient := setupTestClient(ctrl)
+		appManagementClient.EXPECT().
+			GetRecipeMetadata(gomock.Any(), gomock.Any(), gomock.Any()).
+			Return(envRecipe, nil).Times(1)
+
+		outputSink := &output.MockOutput{}
+
+		runner := &Runner{
+			ConnectionFactory: &connections.MockFactory{ApplicationsManagementClient: appManagementClient},
+			Output:            outputSink,
+			Workspace:         &workspaces.Workspace{},
+			Format:            "table",
+			RecipeName:        "default",
+			ResourceType:      "Radius.Resources/openAI",
+		}
+
+		err := runner.Run(context.Background())
+		require.NoError(t, err)
+
+		expected := []any{
+			output.FormattedOutput{
+				Format:  "table",
+				Obj:     recipe,
+				Options: common.RecipeFormat(),
+			},
+			output.LogOutput{
+				Format: "",
+			},
+			output.FormattedOutput{
+				Format:  "table",
+				Obj:     recipeParams,
+				Options: common.RecipeParametersFormat(),
+			},
+		}
+		require.Equal(t, expected, outputSink.Writes)
+	})


Missing test coverage for the case where GetEnvironment returns an EnvironmentResource with nil Properties. This is an important edge case to test since the code needs to handle it gracefully without panicking.

codecov · 2026-01-07T07:26:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.62%. Comparing base (9de83b4) to head (cf6e2c1).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11005      +/-   ##
==========================================
+ Coverage   50.60%   50.62%   +0.01%     
==========================================
  Files         673      673              
  Lines       42271    42283      +12     
==========================================
+ Hits        21393    21407      +14     
+ Misses      18818    18816       -2     
  Partials     2060     2060

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

brooke-hamilton · 2026-01-09T17:29:27Z

🥇 Using the code on this branch I was able to register the persistent volumes recipe with a default parameter value of "banana" (obvious fake value). After registering the recipe, looking at the registered recipe shows the default value:

$ rad recipe show default --resource-type Radius.Compute/persistentVolumes
RECIPE    TYPE                              TEMPLATE KIND  TEMPLATE VERSION  TEMPLATE
default   Radius.Compute/persistentVolumes  terraform                        http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/persistentVolumes-kubernetes.zip

PARAMETER      TYPE      DEFAULT VALUE  MIN       MAX
storage_class  string    banana         -         -

@Alec13355 do you think it makes sense to address the copilot comments on this PR?

radius-functional-tests · 2026-01-21T20:02:54Z

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details

Name	Value
Repository	Alec13355/radius
Commit ref	`b2afa63`
Unique ID	func6ed19cc4aa
Image tag	pr-func6ed19cc4aa

gotestsum 1.13.0
KinD: v0.29.0
Dapr: 1.14.4
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func6ed19cc4aa
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func6ed19cc4aa
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func6ed19cc4aa
controller test image location: ghcr.io/radius-project/dev/controller:pr-func6ed19cc4aa
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func6ed19cc4aa
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Alec13355 requested review from a team as code owners January 6, 2026 15:05

Alec13355 force-pushed the issue-9454 branch from 997abef to 7752e73 Compare January 6, 2026 16:16

Alec13355 temporarily deployed to functional-tests January 6, 2026 16:17 — with GitHub Actions Inactive

Alec13355 temporarily deployed to publish-bicep January 6, 2026 16:17 — with GitHub Actions Inactive

Alec13355 and others added 5 commits January 6, 2026 23:12

Fixes issue where 'rad recipe show' displayed 'null' instead of

506acfd

actual configured parameter values like 'eastus' and 'my-rg'. Signed-off-by: Alec13355 <aah1@mac.com>

Mocking framework all needs method registered or bombs out on test

fd12a37

Signed-off-by: Alec13355 <aah1@mac.com>

Alec13355 force-pushed the issue-9454 branch from 09812bd to d0beb81 Compare January 7, 2026 05:12

Merge branch 'main' into issue-9454

cf6e2c1

ytimocin requested a review from Copilot January 7, 2026 07:11

Copilot started reviewing on behalf of ytimocin January 7, 2026 07:11 View session

Alec13355 temporarily deployed to functional-tests January 7, 2026 07:12 — with GitHub Actions Inactive

Alec13355 temporarily deployed to publish-bicep January 7, 2026 07:12 — with GitHub Actions Inactive

ytimocin reviewed Jan 7, 2026

View reviewed changes

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Merge branch 'main' into issue-9454

b2afa63

brooke-hamilton temporarily deployed to functional-tests January 21, 2026 20:01 — with GitHub Actions Inactive

brooke-hamilton temporarily deployed to publish-bicep January 21, 2026 20:01 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Usability: rad recipe show does not show parameter values #11005

Usability: rad recipe show does not show parameter values #11005

Alec13355 commented Jan 6, 2026 •

edited

Loading

Uh oh!

ytimocin left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

Uh oh!

Copilot AI Jan 7, 2026

Uh oh!

codecov bot commented Jan 7, 2026

Uh oh!

brooke-hamilton commented Jan 9, 2026

Uh oh!

radius-functional-tests bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	if environment != nil && environment.Properties.Recipes != nil {
	if environment != nil && environment.Properties != nil && environment.Properties.Recipes != nil {

Usability: rad recipe show does not show parameter values #11005

Are you sure you want to change the base?

Usability: rad recipe show does not show parameter values #11005

Conversation

Alec13355 commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Contributor checklist

Uh oh!

ytimocin left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 7, 2026

Codecov Report

Uh oh!

brooke-hamilton commented Jan 9, 2026

Uh oh!

radius-functional-tests bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Alec13355 commented Jan 6, 2026 •

edited

Loading

radius-functional-tests bot commented Jan 21, 2026 •

edited

Loading