Skip to content

Conversation

@brooke-hamilton
Copy link
Member

@brooke-hamilton brooke-hamilton commented Jan 23, 2026

Description

This PR updates Go code to use the bicep-types-go package as a standard Go module dependency fetched via go get github.com/Azure/bicep-types/src/bicep-types-go@<commit hash>, rather than relying on the git submodule. The submodule remains for TypeScript/pnpm tooling, but Go tooling now references the package directly from the Azure/bicep-types repository.

This PR is step 1 of 2 in a two-step update to remove the git submodule. The plan is here: radius-project/design-notes#138

Changes:

  • Removed the replace directive in go.mod that pointed to the local submodule
  • Added direct dependency on github.com/Azure/bicep-types/src/bicep-types-go
  • Updated contributor documentation to clarify when the submodule is required

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Related issue #10913

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Go code from using the bicep-types git submodule to using bicep-types-go as a standard Go module dependency. The submodule remains in place for TypeScript/pnpm tooling. This change is part of a broader effort to modernize dependency management and reduce the friction associated with git submodules (as described in issue #10913).

Changes:

  • Removed the replace directive from go.mod that pointed to the local submodule path
  • Added direct dependency on github.com/Azure/bicep-types/src/bicep-types-go with a specific pseudo-version
  • Updated contributor documentation to clarify that the submodule is only required for TypeScript/pnpm tooling, not for Go development

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
go.mod Removed replace directive for local submodule, added direct dependency on bicep-types-go module
go.sum Added checksum entries for the new bicep-types-go module dependency
docs/contributing/contributing-code/contributing-code-building/README.md Updated documentation to clarify that submodule is only needed for TypeScript/pnpm, not Go

Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 23, 2026

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository brooke-hamilton/radius
Commit ref 8c79f38
Unique ID func9ebdac91a2
Image tag pr-func9ebdac91a2
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func9ebdac91a2
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func9ebdac91a2
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func9ebdac91a2
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func9ebdac91a2
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func9ebdac91a2
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@brooke-hamilton brooke-hamilton merged commit e0bdf0a into radius-project:main Jan 24, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants