-
Notifications
You must be signed in to change notification settings - Fork 120
Go module dependency for bicep-types-go instead of submodule #11059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go module dependency for bicep-types-go instead of submodule #11059
Conversation
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the Go code from using the bicep-types git submodule to using bicep-types-go as a standard Go module dependency. The submodule remains in place for TypeScript/pnpm tooling. This change is part of a broader effort to modernize dependency management and reduce the friction associated with git submodules (as described in issue #10913).
Changes:
- Removed the
replacedirective fromgo.modthat pointed to the local submodule path - Added direct dependency on
github.com/Azure/bicep-types/src/bicep-types-gowith a specific pseudo-version - Updated contributor documentation to clarify that the submodule is only required for TypeScript/pnpm tooling, not for Go development
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Removed replace directive for local submodule, added direct dependency on bicep-types-go module |
| go.sum | Added checksum entries for the new bicep-types-go module dependency |
| docs/contributing/contributing-code/contributing-code-building/README.md | Updated documentation to clarify that submodule is only needed for TypeScript/pnpm, not Go |
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
This PR updates Go code to use the
bicep-types-gopackage as a standard Go module dependency fetched viago get github.com/Azure/bicep-types/src/bicep-types-go@<commit hash>, rather than relying on the git submodule. The submodule remains for TypeScript/pnpm tooling, but Go tooling now references the package directly from theAzure/bicep-typesrepository.This PR is step 1 of 2 in a two-step update to remove the git submodule. The plan is here: radius-project/design-notes#138
Changes:
replacedirective ingo.modthat pointed to the local submodulegithub.com/Azure/bicep-types/src/bicep-types-goType of change
Related issue #10913
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: