[fix] Sample.rollout_routed_expert type hint

[gali-leilei]

Infer type hint from testing code, may need review.

[gemini-code-assist]

Summary of Changes

Hello @gali-leilei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the type definition within the Sample class by correcting the type hint for the rollout_routed_experts attribute. The change from a nested list to a numpy.ndarray ensures that the type declaration accurately reflects the expected data structure, thereby enhancing type safety and clarity for components that interact with this specific data.

Highlights

• Type Hint Correction: Updated the type hint for the rollout_routed_experts attribute within the Sample class from list[list[int]] to numpy.ndarray. This change aligns the type definition with the actual data structure used, improving type accuracy and code readability.
• Dependency Addition: Added the import numpy statement to miles/utils/types.py to support the newly introduced numpy.ndarray type hint.

Changelog

• miles/utils/types.py
  • Changed the type hint for Sample.rollout_routed_experts from list[list[int]] to numpy.ndarray.
  • Added import numpy to the file to support the new type hint.

Activity

• The author inferred the correct type hint by referencing existing testing code, indicating a data-driven approach to type correction.
• The author explicitly requested a review for the change, highlighting a desire for validation and feedback on the type inference.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the type hint for rollout_routed_experts from list[list[int]] to numpy.ndarray, which is more specific and helpful. My review includes a suggestion to follow the standard Python convention of importing numpy as np to improve code consistency and readability.