Fix run_glm45 script error when dynamic sampling

[fzyzcjy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @fzyzcjy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an error in the run_glm45_355b_a32b.py script that occurred when dynamic sampling was enabled. The fix ensures that the script correctly evaluates the condition for applying dynamic sampling configurations by referencing the appropriate argument variable.

Highlights

• Script Error Fix: Corrected a variable name from args.true_on_policy to args.mode in the run_glm45_355b_a32b.py script to properly enable dynamic sampling.

Changelog

• scripts/run_glm45_355b_a32b.py
  • Corrected the variable name used in the dynamic sampling conditional check from true_on_policy to mode.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a bug in the run_glm45_355b_a32b.py script. The original code referenced a non-existent attribute args.true_on_policy, which would cause an AttributeError when dynamic sampling is enabled. The fix correctly replaces this with args.mode, aligning with the script's pattern of modifying behavior for the debug_minimal mode. This is a good and necessary correction that prevents a runtime error.