Fix error when launching with arbitrary working dir

[fzyzcjy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @fzyzcjy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issues related to script execution when the application is launched from a working directory other than the repository root. By explicitly defining script paths relative to the repository base and ensuring training scripts use absolute paths, it enhances the robustness and reliability of various utility functions, preventing 'file not found' errors in diverse execution environments.

Highlights

• Path Resolution Fixes: Updated script execution commands in convert_checkpoint and fp8_cast_bf16 to explicitly use repo_base_dir for script paths, ensuring they are correctly located regardless of the current working directory.
• Absolute Training Script Path: Implemented a check in execute_train to convert the train_script to an absolute path if it's not already, preventing issues when launching from arbitrary directories.

Changelog

• miles/utils/external_utils/command_utils.py
  • Modified convert_checkpoint to prefix the convert_hf_to_torch_dist.py script path with repo_base_dir.
  • Modified fp8_cast_bf16 to prefix the fp8_cast_bf16.py script path with repo_base_dir.
  • Added logic in execute_train to make train_script an absolute path if it is not already.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue with launching scripts from arbitrary working directories by converting relative script paths to absolute paths, correctly using a repo_base_dir for prefixing. However, a high-severity command injection vulnerability was identified in the fp8_cast_bf16 function within miles/utils/external_utils/command_utils.py, stemming from direct interpolation of user-supplied paths into a shell command string. This pattern of shell command construction remains a concern throughout the utility module. Additionally, suggestions have been made to improve path joining logic for better cross-platform compatibility by utilizing pathlib's features instead of string formatting.