Fix for exceptions thrown on an unexpected client disconnection.#83
Open
rh101 wants to merge 4 commits intoradu-matei:dotnetcore3from
Open
Fix for exceptions thrown on an unexpected client disconnection.#83rh101 wants to merge 4 commits intoradu-matei:dotnetcore3from
rh101 wants to merge 4 commits intoradu-matei:dotnetcore3from
Conversation
…message. If it's not available then simply dispose of the socket.
…eives a close request from the client, then the server can continue with a normal close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a WebSocket client disconnects without initiating the close handshake, an exception is thrown since the socket will be in an invalid state, so
CloseOutputAsync()shouldn't be called, since there won't be anything to receive this message.Also,
CloseAsync()expects a full close handshake, whereas aCloseOutputAsync()will simply initiate the close and not wait for any response from a client, so in this caseCloseOutputAsyncis the one to use.The API has changed slightly for the
ConnectionManager, since the socket must still be removed on a client disconnection that did not involve the close handshake.