Skip to content

Conversation

@taotieren
Copy link

Description of changes

更新 rkdeveloptool AUR 包地址

@taotieren taotieren requested a review from a team as a code owner November 17, 2025 03:49
Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@jack-ma
Copy link
Contributor

jack-ma commented Nov 17, 2025

Please update the English docs as well.

Copy link
Contributor

@xzl01 xzl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your PR!

Just a quick note: due to PEP 668, modern Linux distributions (like Ubuntu 24.04+) mark the system Python environment as "externally managed," which prevents installing packages via pip at the system level to avoid conflicts with the OS package manager.

To make installation smoother for users on these systems, you might consider:

  • Providing a Debian package (e.g., including a debian/ directory) so the project can be installed via apt, or
  • Relying only on Python dependencies already available as system packages (e.g., python3-xyz) and documenting them clearly.

This would help ensure compatibility and avoid requiring users to override PEP 668 protections. Thanks again for your contribution!

@RadxaStephen
Copy link
Contributor

/windsurf-review

Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".

<Tabs queryString="host-os">
<TabItem value="archlinux" label="Arch Linux">

The rkdeveloptool can be installed from [AUR](https://aur.archlinux.org/packages/rkdeveloptool-gui).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text incorrectly refers to 'rkdeveloptool' instead of 'rkdeveloptool-gui'.

Suggested change
The rkdeveloptool can be installed from [AUR](https://aur.archlinux.org/packages/rkdeveloptool-gui).
The rkdeveloptool-gui can be installed from [AUR](https://aur.archlinux.org/packages/rkdeveloptool-gui).

git clone https://github.com/gahingwoo/RKDevelopTool-GUI.git
cd RKDevelopTool-GUI
pip install -r requirements.txt
python -m build_nuitka.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python command syntax looks incorrect. If build_nuitka.py is a script file (not a module), it should be executed directly:

Suggested change
python -m build_nuitka.py
python build_nuitka.py

git clone https://github.com/gahingwoo/RKDevelopTool-GUI.git
cd RKDevelopTool-GUI
pip install -r requirements.txt
python -m build_nuitka.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python command syntax looks incorrect here as well:

Suggested change
python -m build_nuitka.py
python build_nuitka.py

@jack-ma jack-ma closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants