Use logarithmic scale on LADSPA inputs that request it#6
Open
bennigraf wants to merge 3 commits intoraedwulf:masterfrom
Open
Use logarithmic scale on LADSPA inputs that request it#6bennigraf wants to merge 3 commits intoraedwulf:masterfrom
bennigraf wants to merge 3 commits intoraedwulf:masterfrom
Conversation
|
It seems the log scaling is still not applied when the bin file needs creating with the default value. See LADSPADefault() in ladspa_utils.c for details. The log hint bit of HintDescriptor should not be masked off by LADSPA_HINT_DEFAULT_MASK when judging it with LADSPA_IS_HINT_LOGARITHMIC(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi raedwulf,
I'm not sure what the current state of this repo is, but you seem to be at least inofficially the maintainer of this plugin for now, so I'd like to suggest an improvement to it. I tried to use this with the parametric EQ from the CAPS collection; however, I had the problem that the frequency control was mapped linearly from 20Hz to 14kHz over 0-100%, which is not very useful, especially in the low end range. LADSPA plugins do have a way of suggesting to use a logarithmic scale for input controls, though. This PR tries to detect such inputs and then apply control values after scaling them logarithmically over the min/max range. For me, this allows way better control of i.e. the Eq4p freqency.
The code might be a bit rough since I'm not a full time C developer; let me know if you have improvements to suggest.
Best,
Benjamin.