Conversation
micmro
commented
Apr 19, 2022
| { | ||
| input: 'dist/esm/types/index.d.ts', | ||
| output: [{ file: 'dist/index.d.ts', format: 'esm' }], | ||
| plugins: [dts(), command('rm -r dist/{cjs,esm}/types')], |
Collaborator
Author
There was a problem hiding this comment.
removed generated types so only the dts rolled-up definitions are published
| modules: true, | ||
| use: ['sass'], | ||
| }), | ||
| typescript({ tsconfig: './tsconfig.build.json' }), |
Collaborator
Author
There was a problem hiding this comment.
use tsconfig.build.json so VS code allows typing for tests and storybook
| sourcemap: true, | ||
| }, | ||
| ], | ||
| external: ['react', 'react-dom'], |
Collaborator
Author
There was a problem hiding this comment.
make react external so it does not get bundled
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "extends": "./tsconfig.json", | |||
Collaborator
Author
There was a problem hiding this comment.
extend the basic TypeScript config but overwrite exclude for the build
Comment on lines
-40
to
-42
| "plugins": [ | ||
| { "name": "typescript-plugin-css-modules" } | ||
| ] |
| { | ||
| // see https://www.typescriptlang.org/tsconfig to better understand tsconfigs | ||
| "include": ["src/custom.d.ts","src", "types"], | ||
| "exclude": ["**/*.test.tsx", "**/*.stories.tsx"], |
Collaborator
Author
There was a problem hiding this comment.
This prevented tests and storied from getting type checked
| // `tsdx build` ignores this option, but it is commonly used when type-checking separately with `tsc` | ||
| // "noEmit": true, | ||
| "declarationDir": "types", | ||
| "typeRoots": ["./node_modules/@types/", "./src/custom.d.ts", "./src/react-app-env.d.ts"], |
Collaborator
Author
There was a problem hiding this comment.
not actually needed
| "react-is": "^17.0.2", | ||
| "react-test-renderer": "^17.0.2", | ||
| "rollup": "^2.70.1", | ||
| "rollup-plugin-command": "^1.1.3", |
Collaborator
Author
There was a problem hiding this comment.
moved to dev-dependencies
Comment on lines
-123
to
-127
| "rollup-plugin-copy": "^3.4.0", | ||
| "rollup-plugin-import-css": "^3.0.3", | ||
| "rollup-plugin-sass": "^1.2.12", | ||
| "rollup-plugin-styles": "^4.0.0", | ||
| "typescript-plugin-css-modules": "^3.4.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.