Fix: resolve mainTargetClassName correctly to handle activity aliases#7
Open
bunnyjaura wants to merge 1 commit intorafaelsetragni:mainfrom
Open
Fix: resolve mainTargetClassName correctly to handle activity aliases#7bunnyjaura wants to merge 1 commit intorafaelsetragni:mainfrom
bunnyjaura wants to merge 1 commit intorafaelsetragni:mainfrom
Conversation
Updated updateMainTargetClassName() to check activityInfo.targetActivity before falling back to activityInfo.name. This ensures the correct main activity is used when a launcher alias is defined.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When creating notifications in apps that use , the NotificationBuilder
was setting
mainTargetClassNameusing onlyactivityInfo.name. This caused a crash:because the launcher alias did not have a direct activity class associated with it.
Solution
Updated
updateMainTargetClassName()to:activityInfo.targetActivityfirst.activityInfo.nameiftargetActivityis null.This ensures that
mainTargetClassNamealways points to a valid activity class,even when the launcher entry is an alias.
Testing