Skip to content

Fix for pull request #11 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
br3nt wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix for pull request #11 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
771ef54
Commands that fail should return a non-zero exit status.
Nov 4, 2015
e1efcd2
Merge pull request #1 from dbezborodovrp/master
jeffcressman Apr 12, 2017
10e9661
Fix for `unexpected return (LocalJumpError)` error
br3nt Apr 19, 2017
7f45a5c
Removed rescue of `Exception`
br3nt Apr 19, 2017
c466082
Add backtrace to STDERR for unhandled exceptions
br3nt Apr 19, 2017
a50bac6
Test for non-zero exit status after running cmd
br3nt Apr 19, 2017
205e4a7
Merge pull request #2 from br3nt/patch-1
jeffcressman Apr 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions bin/karo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ require 'karo'
begin
Karo::CLI.start(ARGV)
rescue SystemExit, Interrupt
puts "Exiting"
rescue Exception => e
puts e
STDERR.puts "Exiting"
rescue => e
STDERR.puts "karo: Error: #{e}"
STDERR.puts e.backtrace
exit 1
end
3 changes: 3 additions & 0 deletions lib/karo/common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ def make_command(configuration, namespace, command, extras)
def run_it(cmd, verbose=false)
say cmd, :green if verbose
system cmd unless options[:dryrun]
if $?.exitstatus != 0
raise "Non-zero exit code (#{$?.exitstatus}) returned from #{cmd.strip}"
end
end

def git_repo
Expand Down