Skip to content

Fix ActiveResource::HttpMock.enable_net_connection! when Connection is first used #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
+9 −2
Merged

Fix ActiveResource::HttpMock.enable_net_connection! when Connection is first used #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/active_resource/http_mock.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,11 +375,11 @@ def http_stub
end

def unstub_http?
HttpMock.net_connection_enabled? && defined?(@http) && @http.kind_of?(HttpMock)
HttpMock.net_connection_enabled? && (!defined?(@http) || @http.kind_of?(HttpMock))
end

def stub_http?
HttpMock.net_connection_disabled? && defined?(@http) && @http.kind_of?(Net::HTTP)
HttpMock.net_connection_disabled? && (!defined?(@http) || @http.kind_of?(Net::HTTP))
end
end
end
Expand Down
7 changes: 7 additions & 0 deletions test/cases/connection_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,13 @@ def test_enable_net_connection
end
end

def test_enable_net_connection_first_time
keep_net_connection_status do
ActiveResource::HttpMock.enable_net_connection!
assert @conn.send(:http).kind_of?(Net::HTTP)
end
end

def test_disable_net_connection
keep_net_connection_status do
ActiveResource::HttpMock.enable_net_connection!
Expand Down
Loading