Ensure god starts correctly after first install#10
Open
mhaylock wants to merge 2 commits intorailsmachine:masterfrom
Open
Ensure god starts correctly after first install#10mhaylock wants to merge 2 commits intorailsmachine:masterfrom
mhaylock wants to merge 2 commits intorailsmachine:masterfrom
Conversation
Without these changes the execution order can change and god can be restarted without all the configuration files being in place or the gem being installed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the resource dependencies to ensure that the gem and configuration files are all in place before Puppet will attempt to restart it.
This problem was previously raised with #5, an attempt to fix was made but myself and others still observe it failing.
In practice the exact symptom I was seeing was the god does end up started thanks to the capistrano task
god:restart, but the daemon is not being monitored (i.e.sudo status godreturnsgod stop/waitingrather than something likegod start/running, process 31872).