After terminating god, restart it using Upstart#11
Open
mhaylock wants to merge 1 commit intorailsmachine:masterfrom
Open
After terminating god, restart it using Upstart#11mhaylock wants to merge 1 commit intorailsmachine:masterfrom
mhaylock wants to merge 1 commit intorailsmachine:masterfrom
Conversation
This avoids Upstart trying to restart god after the `god terminate` then conflicting with the previously used direct instantiation of god (which wasn't daemonized anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the 'god:restart' task
god terminateis run - when this completes Upstart will detect this and restart god automatically. The current implementation then tries to start a non-daemonized god process (i.e. runsgod -c /etc/god/god.conf) which then conflicts with the socket already reserved by the daemonized process started by Upstart.Due to this my log file would have entries like:
In this PR I've change it to use
start god || truewhich instructs Upstart to start the process if it hasn't already, and ignore it if it has already started it. With this fix in place god restart cleanly without any error messages.