Additional helpers preparing Virtual Raindex for usage in RaindexClient#2176
Additional helpers preparing Virtual Raindex for usage in RaindexClient#2176hardyjosh wants to merge 162 commits into2025-10-01-vr-event-streamfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
| )); | ||
| } | ||
|
|
||
| #[cfg(wasm_test)] |
There was a problem hiding this comment.
I noticed the [allow(unexpected_cfgs)] at top of the file, but don't think #[cfg(wasm_test)] works here?
as I don't see any changes to the flake command nor the ci steps commands, and didn't find anything about this cfg in the wasm-bindgen docs either, so I don't think this test is running at all by the wasm test flake command and actually I think it doesn't even compile. as I checked the workflow runs and didn't find this test running at all in the logs either.
for that to run this test, we need to include this crate in the command and set this cfg to normal test and if its only suppose to run in wasm env, it should be configured through target_family = wasm as far as I know
Caution
This PR is chained to #2175
Motivation
Solution
VirtualRaindex::from_snapshot[_bundle].StaticCodeCachewith validated upserts, bulk loaders, and new error variants.Checks
By submitting this for review, I'm confirming I've done the following: