Skip to content

Additional helpers preparing Virtual Raindex for usage in RaindexClient#2176

Open
hardyjosh wants to merge 162 commits into2025-10-01-vr-event-streamfrom
2025-10-03-vr-live-quote
Open

Additional helpers preparing Virtual Raindex for usage in RaindexClient#2176
hardyjosh wants to merge 162 commits into2025-10-01-vr-event-streamfrom
2025-10-03-vr-live-quote

Conversation

@hardyjosh
Copy link
Contributor

@hardyjosh hardyjosh commented Oct 3, 2025

Caution

This PR is chained to #2175

Motivation

  • Virtual snapshots were export-only; the client needs import/replay support.
  • We also need first-class cache ingestion APIs and wasm-friendly serialization.

Solution

  • Add serde-friendly snapshot bundle types + VirtualRaindex::from_snapshot[_bundle].
  • Extend StaticCodeCache with validated upserts, bulk loaders, and new error variants.
  • Cover snapshot/cache round trips in tests (with wasm smoke guard)

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@hardyjosh hardyjosh requested a review from findolor October 3, 2025 14:20
@hardyjosh hardyjosh self-assigned this Oct 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 2025-10-03-vr-live-quote

Comment @coderabbitai help to get the list of available commands and usage tips.

@hardyjosh hardyjosh mentioned this pull request Oct 8, 2025
4 tasks
@hardyjosh hardyjosh requested review from 0xgleb and rouzwelt October 8, 2025 10:54
));
}

#[cfg(wasm_test)]
Copy link
Contributor

@rouzwelt rouzwelt Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the [allow(unexpected_cfgs)] at top of the file, but don't think #[cfg(wasm_test)] works here?
as I don't see any changes to the flake command nor the ci steps commands, and didn't find anything about this cfg in the wasm-bindgen docs either, so I don't think this test is running at all by the wasm test flake command and actually I think it doesn't even compile. as I checked the workflow runs and didn't find this test running at all in the logs either.

for that to run this test, we need to include this crate in the command and set this cfg to normal test and if its only suppose to run in wasm env, it should be configured through target_family = wasm as far as I know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants