Add support for M1 Macs #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we haven't been able to find an appropriate copy of protoc then build-cmd should return nil in order to prevent compile-proto! from executing a malformed command line.
If Leiningen fails to return a value for either the operating system or architecture then we emit a warning message explaining what happened.
Versions of com.google.protobuf/protoc prior to 3.17.3 don't ship binaries suitable for Apple Arm chips. Those laptops can run the x86_64 versions of protoc, so for versions before 3.17.3 we choose that architecture instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of
com.google.protobuf/protocprior to 3.17.3 don't ship binaries suitable for Apple Arm chips. Those machines can run thex86_64versions of protoc, so for versions before 3.17.3 we choose that architecture instead.Also, improve the error messages for when lein-protoc is used on an unsupported OS or architecture.