Refactor generation of procServ messages #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
C++11 is probably fine. |
Contributor
Author
|
Not a bad idea. Please check if I added it in the right spot - autoconf predates my days as a software developer ;-) |
Contributor
Author
|
@ralphlange any idea how to deal with the failing AppVeyor build? On Debian |
Replace fixed size char string buffers by std::string to rule out buffer overflows/truncating strings. By doing so we get rid of some compiler warnings.
mark0n
force-pushed
the
dont-truncate-strings
branch
from
1aa9a5b to
4b2aa0b
Compare
mark0n
force-pushed
the
dont-truncate-strings
branch
2 times, most recently
from
79097e5 to
78bba23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace fixed size char string buffers by std::string to rule out buffer overflows/truncating strings. By doing so we get rid of some compiler warnings.
Note: These changes leverage C++14 features but at the cost of some readability this could also be done with C++11 or even C++98. Which standard version are we shooting for?