This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Fixed issue where paths with URL encoded characters were being passed…#155
Open
drb wants to merge 1 commit intoraml-org:masterfrom
Open
Fixed issue where paths with URL encoded characters were being passed…#155drb wants to merge 1 commit intoraml-org:masterfrom
drb wants to merge 1 commit intoraml-org:masterfrom
Conversation
… to the filesystem when attempting to load a file using fetchLocalFileAsync(), causing an exception to be raised.
|
Can you add a test to verify the regression? |
|
Also just to double, check, have you signed the Contributor agreement? |
Author
|
I'll add a test ASAP. Contrib agreement is signed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to the filesystem when attempting to load a file using fetchLocalFileAsync(), causing an exception to be raised.
Using a path like
path/to a file/file.ramlwould be passed to the method aspath/to%20a%20file/file.ramlwhich would raise an exception from the call to fs.readFile. A simple patch has been added to normalize urlencoded strings before being passed into this method.